docs: add steps for running addons + npm tests #6231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
force-pushed
the
expanded-test-info
branch
from
35b17f5 to
f0f6276
Compare
|
LGTM but s/docs:/doc:/ in the commit log. |
MylesBorins
force-pushed
the
expanded-test-info
branch
from
f0f6276 to
550d2ac
Compare
|
updated
|
BUILDING.md
Outdated
There was a problem hiding this comment.
This doesn't render correctly. Try viewing the rendered version.
MylesBorins
force-pushed
the
expanded-test-info
branch
2 times, most recently
from
7ffeb2d to
4ff78d5
Compare
|
LGTM |
BUILDING.md
Outdated
There was a problem hiding this comment.
Why not put this in a text block like the others?
There was a problem hiding this comment.
v5 > all use the internal npm to run the tests. No need to install.
|
LGTM with a nit |
|
I'm not sure we want to require a make install to be able to run the tests. We've had this break in the past and have fixed it |
|
afaik this has always been the case for npm2 and fixing it is non trivial |
|
@mhdawson have your opinions on this pr changed? |
|
Just talking to Richard to understand what the issue he was seeing and to understand if there is any other work around besides running make install. If there is one we might want to include in the docs as well. |
estliberitas
force-pushed
the
master
branch
2 times, most recently
from
7da4fd4 to
c7066fb
Compare
|
@mhdawson any movement on this? |
|
Sorry, should have commented earlier. Since it reflects what is currently the case I think we should go ahead and land, and if we decide to change anything in 4.X at some point we can update then. LGTM. |
MylesBorins
force-pushed
the
expanded-test-info
branch
from
4ff78d5 to
e2b44c3
Compare
Currently we do not document how to run the test suite for native modules or for npm. This commit updates BUILDING.md with the information needed to do so. It includes a caveat about Node v4 and earlier requiring `make install` to be run before running the npm test suite. PR-URL: nodejs#6231 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
force-pushed
the
expanded-test-info
branch
from
e2b44c3 to
10a60a1
Compare
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2016
Currently we do not document how to run the test suite for native modules or for npm. This commit updates BUILDING.md with the information needed to do so. It includes a caveat about Node v4 and earlier requiring `make install` to be run before running the npm test suite. PR-URL: #6231 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
Currently we do not document how to run the test suite for native modules or for npm. This commit updates BUILDING.md with the information needed to do so. It includes a caveat about Node v4 and earlier requiring `make install` to be run before running the npm test suite. PR-URL: #6231 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 18, 2016
Currently we do not document how to run the test suite for native modules or for npm. This commit updates BUILDING.md with the information needed to do so. It includes a caveat about Node v4 and earlier requiring `make install` to be run before running the npm test suite. PR-URL: #6231 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we do not document how to run the test suite for native
modules or for npm. This commit updates BUILDING.md with the
information needed to do so. It includes a caveat about Node v4
and earlier requiring
make installto be run before running the npmtest suite.